Skip to content

MNTOR-5264: add active user filter to subscriber queries#6602

Merged
EMMLynch merged 2 commits into
mainfrom
MNTOR-5264
Apr 15, 2026
Merged

MNTOR-5264: add active user filter to subscriber queries#6602
EMMLynch merged 2 commits into
mainfrom
MNTOR-5264

Conversation

@mansaj
Copy link
Copy Markdown
Collaborator

@mansaj mansaj commented Apr 14, 2026

References:

Jira: MNTOR-5264
Figma:

Description

  • rework the getBreachNotificationSubscribersByHashes function to include an activeWithinMs filter for subscribers and email addresses. This change ensures that only active users within the specified timeframe are retrieved, capping the amount of emails sent for breaches
  • corresponding database query functions to accept this new filter option.

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Copy link
Copy Markdown
Collaborator

@joeherm joeherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- good test cases 👍🏻

@EMMLynch EMMLynch enabled auto-merge April 15, 2026 13:07
@EMMLynch EMMLynch added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 53aa6c0 Apr 15, 2026
19 checks passed
@EMMLynch EMMLynch deleted the MNTOR-5264 branch April 15, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants