Skip to content

fix(icons): making caching last step of syncBreaches job#6623

Merged
joeherm merged 1 commit into
mainfrom
MNTOR-5251/recent-breach-no-icons-followup
May 7, 2026
Merged

fix(icons): making caching last step of syncBreaches job#6623
joeherm merged 1 commit into
mainfrom
MNTOR-5251/recent-breach-no-icons-followup

Conversation

@joeherm
Copy link
Copy Markdown
Collaborator

@joeherm joeherm commented May 6, 2026

References:

Jira: MNTOR-5251

Description

  • We are overwriting the Redis cache key in syncJobs before we've fetched logos
  • Move caching to be the final step of the cron

Screenshot (if applicable)

Not applicable.

How to test

  • I looked into Redis in staging and none of the entries have a favicon_url
  • Running locally the script now populates favicon_url in Redis
  • Added unit tests to catch potential issues in the future

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@joeherm joeherm requested review from Vinnl and kschelonka May 6, 2026 15:36
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, that's a bunch of mocking, what a hassle 😅

@joeherm joeherm added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 9a62222 May 7, 2026
18 of 19 checks passed
@joeherm joeherm deleted the MNTOR-5251/recent-breach-no-icons-followup branch May 7, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants