MNTOR-5282 - Add email dark mode per guide#6663
Merged
Merged
Conversation
codemist
commented
May 20, 2026
| // which surfaces participate (`dm-body`, `dm-section-hero`, `dm-section-card`, | ||
| // `dm-section-footer`, `dm-img-light` / `dm-img-dark`). | ||
| export const HeaderStyles = () => { | ||
| const bodyBg = "#1c1b22"; |
Collaborator
Author
There was a problem hiding this comment.
The hero section was still #F5EAFF (light purple), the footer wrapper was #F9F9FA (light gray), the body was white. So when the swap fired, the new white-text dark logo was sitting on a light-colored section, readable on Storybook (where you see the whole email), but on a real client it looks like a white logo on a bright box. That's the "purple field under the Monitor logo" QA reported.
joeherm
approved these changes
May 20, 2026
Collaborator
joeherm
left a comment
There was a problem hiding this comment.
Looks good and appreciate the technique references listed. Not 100% sure on the testing side (can leave that to QA since it's client dependent), but code looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5282
Figma:
Description
QA identified that the new work-arounds introduced more negative changes. I reviewed a few pieces of documentation
https://www.emailonacid.com/blog/article/email-development/advanced-mjml-coding/
https://www.litmus.com/blog/the-ultimate-guide-to-dark-mode-for-email-marketers
to guide me on adding dark mode support, e.g. swap to white-text variants, and the hero/card/footer/body backgrounds darken so the swapped logos and body text remain readable instead of sitting on light-colored "fields."
How to test
We can't really test this until it's on stage.
Checklist (Definition of Done)