MNTOR-5282 - Enforce background for breach alert email images#6686
Merged
Conversation
Vinnl
approved these changes
May 26, 2026
Collaborator
Vinnl
left a comment
There was a problem hiding this comment.
For some extra polish, you could add some padding to the background colours, and maybe give them rounded corners, to stand out a little less starkly against dark backgrounds.
(But also: screw hacky dark modes :P)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5282
Description
Unfortunately, the workaround only worked on Gmail iOS, not Gmail Android. I decided to move forward by applying the background colours directly into the images themselves and enforcing light mode where possible. Light mode enforcement still doesn’t fully work in Gmail since the client can continue to dark-mode the image, but embedding the background directly into the asset should at least keep the content accessible and legible. This is the best approach I can implement right now to maintain readability across clients.
As discussed also can’t delete the old images right now, but I’d still like to keep the new ones I introduced for the different email variant experiments. I stored them using a
breach-alerts-YYYYMMDDnaming format so we can keep track of iterations more easily while we continue testing and refining the templates.Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)