Skip to content

Improve the logic to move bugs out of Firefox::General #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suhaibmujahid merged 2 commits into from
Apr 10, 2026
+21 −15
Merged

Improve the logic to move bugs out of Firefox::General #2854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57fe947
Remove Core::Internationalization hack in the component script becaus…
marco-c Apr 9, 2026
0ca0f8a
Use componentspecific model to choose when to move bugs out of Firefo…
marco-c Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions bugbot/rules/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,20 @@ def meets_threshold(bug_data):
# Classify those bugs
bugs = get_bug_ids_classification("component", bug_ids)

# For Firefox::General bugs, use the componentspecific model to decide
# whether to move them out of General.
ff_general_bug_ids = [
bug_id
for bug_id in bug_ids
if raw_bugs[bug_id]["product"] == "Firefox"
and raw_bugs[bug_id]["component"] == "General"
]
componentspecific_results = {}
if ff_general_bug_ids:
componentspecific_results = get_bug_ids_classification(
"componentspecific", ff_general_bug_ids
)

fenix_general_bug_ids = []
for bug_id, bug_data in bugs.items():
if not bug_data.get("available", True):
Expand Down Expand Up @@ -187,14 +201,12 @@ def meets_threshold(bug_data):
}:
continue

# Don't move bugs from Firefox::General to Core::Internationalization.
if (
bug["product"] == "Firefox"
and bug["component"] == "General"
and suggested_product == "Core"
and suggested_component == "Internationalization"
):
continue
# For Firefox::General bugs, only proceed if the componentspecific
# model is confident enough that the bug should be moved out.
if bug["product"] == "Firefox" and bug["component"] == "General":
cs = componentspecific_results.get(bug_id, {})
if cs["prob"][1] < self.general_confidence_threshold:
continue

result = {
"id": bug_id,
Expand All @@ -208,13 +220,7 @@ def meets_threshold(bug_data):
if self.frequency == "daily":
results[bug_id] = result

confidence_threshold_conf = (
"confidence_threshold"
if bug["component"] != "General"
else "general_confidence_threshold"
)

if prob[index] >= self.get_config(confidence_threshold_conf):
if prob[index] >= self.component_confidence_threshold:
self.autofix_component[bug_id] = {
"product": suggested_product,
"component": suggested_component,
Expand Down