Skip to content

Add reviewer_status enum and fields#5704

Merged
suhaibmujahid merged 1 commit intomozilla:masterfrom
suhaibmujahid:reviewer_status
Feb 20, 2026
Merged

Add reviewer_status enum and fields#5704
suhaibmujahid merged 1 commit intomozilla:masterfrom
suhaibmujahid:reviewer_status

Conversation

@suhaibmujahid
Copy link
Member

Follow up on #5684

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Review Helper API by adding a ReviewerStatus enum and corresponding fields to track the specific status of reviewers (e.g., blocking, accepted, rejected). The changes refactor existing schemas to use a common base class that handles user action fields, and adds support for compound acting_capacity values that can encode both the capacity and reviewer status.

Changes:

  • Added ReviewerStatus enum with 8 status values (blocking, added, accepted, rejected, commented, accepted-older, rejected-older, resigned)
  • Created UserActionBase schema base class with validation logic for acting_capacity and reviewer_status fields
  • Refactored ReviewRequestCreate and FeedbackCreate schemas to inherit from UserActionBase
  • Updated database models and routers to handle the new reviewer_status field
  • Added Alembic migration to create the reviewer_status enum type and add columns to review_requests and feedback tables

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
services/reviewhelper-api/app/enums.py Adds ReviewerStatus enum with 8 status values
services/reviewhelper-api/app/schemas/base.py Creates UserActionBase with field extraction and validation logic
services/reviewhelper-api/app/schemas/review_request.py Refactors ReviewRequestCreate to inherit from UserActionBase
services/reviewhelper-api/app/schemas/feedback.py Refactors FeedbackCreate to inherit from UserActionBase
services/reviewhelper-api/app/database/models.py Adds reviewer_status column to ReviewRequest and Feedback models
services/reviewhelper-api/app/routers/request.py Passes reviewer_status when creating review requests
services/reviewhelper-api/app/routers/feedback.py Passes reviewer_status when creating and updating feedback
services/reviewhelper-api/alembic/versions/b4e3f7a92c01_add_reviewer_status_column.py Migration to add reviewer_status enum and columns (has critical filename bug)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@suhaibmujahid suhaibmujahid merged commit 31bf1c9 into mozilla:master Feb 20, 2026
0 of 6 checks passed
@suhaibmujahid suhaibmujahid deleted the reviewer_status branch February 20, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments