This repository was archived by the owner on Aug 5, 2019. It is now read-only.
Merged
Conversation
added 2 commits
July 5, 2019 16:41
Closed
marco-c
reviewed
Jul 5, 2019
marco-c
reviewed
Jul 5, 2019
|
|
||
| // Display message as main output | ||
| // Display helpers | ||
| function canDisplay() { |
Collaborator
There was a problem hiding this comment.
Why do we need this? Don't we always call the display functions when everything is ready?
Contributor
Author
There was a problem hiding this comment.
This is for this execution of hide & message which is in load: it's called when dom is not yet ready on first load, but is nice to have for later calls, as this loading time is a bit long.
marco-c
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡
Fixes #57