Check if we are able to trigger bugbug's hook

[marco-c]

I can't be sure yet, but I believe

code-review/events/code_review_events/workflow.py

Lines 167 to 171 in 6c8ae78

	task = self.hooks.triggerHook(
	"project-relman",
	"bugbug-classify-patch",
	{"DIFF_ID": build.diff_id},
	)

will fail, as bugbug is in community-tc and code-review in firefox-ci.

[La0]

Yeah, i don't see how it can work, except if we store community-tc credentials in the firefox-ci secret...

The good solution is to move risk-analysis events into its own bugbug sub-project, using libmozevent. The project would then live in community-ci alongside the rest of bugbug.

[marco-c]

Yeah, i don't see how it can work, except if we store community-tc credentials in the firefox-ci secret...

We can do this I guess, it shouldn't be too hard.

The good solution is to move risk-analysis events into its own bugbug sub-project, using libmozevent. The project would then live in community-ci alongside the rest of bugbug.

It depends on how we intend to integrate the risk analysis results on Phab in the future. If it's going to be a different build on Phab, it could be totally separate from the current bot. Otherwise, it's going to have to be linked somehow.
One possibility could be to make the "classify patch" a API of the bugbug server, so the code review bot doesn't have to trigger the hook.

[La0]

The same phab build plan can have multiple HTTP notifications, hence triggering multiple backends.

[marco-c]

The same phab build plan can have multiple HTTP notifications, hence triggering multiple backends.

That's another possibility, but it would still have the problem that the code review bot would not know of the risk analysis result.

[La0]

The classify patch should push its result in the backend.

[marco-c]

That's another possibility. Let's discuss all our options in the next few days and decide on the way forward.
(for now we can just fix the current behavior by using community-tc from firefox-ci)

[La0]

I created 2 clients on the community-ci instance:

• project/relman/bugbug/code-review-testing
• project/relman/bugbug/code-review-production

Both clients simply have the scope hooks:trigger-hook:project-relman/bugbug-classify-patch

[La0]

And requested the changes in Bugzilla

[marco-c]

Things are working now, e.g. https://community-tc.services.mozilla.com/tasks/Cdrk0eYHToOI21CsEPIXFw.