bot: Send email to differential owner when build failures are encountered, fixes #99#124
Merged
La0 merged 1 commit intomozilla:masterfrom Sep 30, 2019
Merged
Conversation
La0
requested changes
Sep 27, 2019
Collaborator
La0
left a comment
La0
left a comment
There was a problem hiding this comment.
Mostly looks good, some small changes and we should be good to run on testing
abpostelnicu
force-pushed
the
email_notify
branch
from
2722f34 to
e8a5116
Compare
abpostelnicu
force-pushed
the
email_notify
branch
from
e8a5116 to
c3b97ae
Compare
La0
approved these changes
Sep 30, 2019
| return self.nb % 2 == 0 | ||
|
|
||
| def is_build_error(self): | ||
| return self.nb % 4 == 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
Phabricatordoesn't offer support for sending email when UnitTest failures happen we need to have this specific implementation in order to inform patch owners when build failure happen.