Skip to content

Publish revision on backend once repo is known #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
La0 merged 1 commit into from
Oct 31, 2019
Merged

Publish revision on backend once repo is known #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bot/code_review_bot/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ def run(self, revision):
# Analyze revision patch to get files/lines data
revision.analyze_patch()

# Store the revision in the backend
self.backend_api.publish_revision(revision)

# Find issues on remote tasks
issues = self.find_issues(revision)
if not issues:
Expand Down Expand Up @@ -221,6 +218,10 @@ def find_issues(self, revision):
# Update the local revision with tasks
revision.setup_try(tasks)

# Store the revision in the backend
# It needs to be after setup_try to have a repository value
self.backend_api.publish_revision(revision)

# Load task description
task = tasks.get(settings.try_task_id)
assert task is not None, "Missing task {}".format(settings.try_task_id)
Expand Down