Skip to content

Use Heroku SSL headers to build https:// urls#214

Merged
La0 merged 1 commit intomozilla:masterfrom
La0:heroku-ssl
Nov 6, 2019
Merged

Use Heroku SSL headers to build https:// urls#214
La0 merged 1 commit intomozilla:masterfrom
La0:heroku-ssl

Conversation

@La0
Copy link
Copy Markdown
Collaborator

@La0 La0 commented Nov 6, 2019

Testing now as I just got the domains + SSL certs...

@La0 La0 added the backend Code review backend label Nov 6, 2019
@La0 La0 requested a review from marco-c November 6, 2019 14:50
@La0 La0 self-assigned this Nov 6, 2019
@La0
Copy link
Copy Markdown
Collaborator Author

La0 commented Nov 6, 2019

It works : the testing backend now builds https urls

curl https://api.code-review.testing.moz.tools/v1/
{
    "diff": "https://api.code-review.testing.moz.tools/v1/diff/",
    "repository": "https://api.code-review.testing.moz.tools/v1/repository/",
    "revision": "https://api.code-review.testing.moz.tools/v1/revision/"
}

@La0 La0 merged commit b2e5256 into mozilla:master Nov 6, 2019
@La0 La0 deleted the heroku-ssl branch November 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Code review backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants