Support full file issues reported at line 0#238
Merged
La0 merged 4 commits intomozilla:masterfrom Nov 15, 2019
Merged
Conversation
Collaborator
|
We could instead make the license analyzer follow our JSON standard and make it return None instead of 0 as the line |
Collaborator
As discussed on IRC, let's support 0 as None, but let's log an error on Sentry so we can fix analyzers that use 0 to mean full file to use None instead, and analyzers who use 0 as first line to add +1 to their lines. |
Collaborator
Author
|
@marco-c I updated the bot's code to send a warning on line 0, and falling back to full file mode |
marco-c
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this code, the licence checks are now reported: Example on phab-dev
The coverage issue are now also considered full file issues (which makes sense too)
Fixes #230