Move Issue non hashed attributes to IssueLInk#2451
Merged
Archaeopteryx merged 14 commits intomozilla:masterfrom Oct 23, 2024
Merged
Move Issue non hashed attributes to IssueLInk#2451Archaeopteryx merged 14 commits intomozilla:masterfrom
Archaeopteryx merged 14 commits intomozilla:masterfrom
Conversation
vrigal
force-pushed
the
issuelink-in-patch-new
branch
from
b90ac6a to
7c40d1c
Compare
Collaborator
Author
|
Almost done, still few failures detected from tests:
|
Merged
vrigal
force-pushed
the
issuelink-in-patch-new
branch
from
7c40d1c to
01ca29d
Compare
vrigal
force-pushed
the
issuelink-in-patch-new
branch
from
01ca29d to
6094d4f
Compare
Collaborator
|
I'll check if we need to move other attributes in this PR (line positions). |
added 2 commits
October 22, 2024 12:18
La0
force-pushed
the
issuelink-in-patch-new
branch
from
84077da to
ab71047
Compare
La0
changed the title
Archaeopteryx
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2448
This PR moves the following attributes from
Issuemodel up toIssueLink:new_for_revisionin_patchlinenb_linescharThese attributes are not in the hash payload, so they should not be on the
Issuemodel as we want to set a unique constraint on the hash later on (see #2447 )The API endpoints remain compatible with the previous implementation so that the bot can simply provide a list of attributes that will result in creation of Issue+IssueLink
Both
load_issuescommand & the frontend remain working as exepcted