Skip to content

Use official TaskclusterConfig#257

Merged
La0 merged 4 commits intomozilla:masterfrom
La0:use-tc-config
Dec 3, 2019
Merged

Use official TaskclusterConfig#257
La0 merged 4 commits intomozilla:masterfrom
La0:use-tc-config

Conversation

@La0
Copy link
Copy Markdown
Collaborator

@La0 La0 commented Nov 21, 2019

⚠️ Won't work until a new taskcluster client library release is made with taskcluster/taskcluster#2028

@La0 La0 added enhancement New feature or request bot Code review bot backend Code review backend labels Nov 21, 2019
@La0 La0 self-assigned this Nov 21, 2019
Copy link
Copy Markdown
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving for when the time comes ;)

@La0
Copy link
Copy Markdown
Collaborator Author

La0 commented Nov 21, 2019

Thanks Marco ! It lacks the taskcluster version bump though, as i can't predict the right version

@La0 La0 marked this pull request as ready for review December 3, 2019 08:29
@La0
Copy link
Copy Markdown
Collaborator Author

La0 commented Dec 3, 2019

We now have access to TaskclusterConfig in taskcluster==24.0.0 🎉

@La0 La0 merged commit d510e77 into mozilla:master Dec 3, 2019
@La0 La0 deleted the use-tc-config branch December 3, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Code review backend bot Code review bot enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants