events: Don't register for pulse notifications when publication is disabled#262
Merged
La0 merged 3 commits intomozilla:masterfrom Nov 25, 2019
Merged
events: Don't register for pulse notifications when publication is disabled#262La0 merged 3 commits intomozilla:masterfrom
La0 merged 3 commits intomozilla:masterfrom
Conversation
La0
requested changes
Nov 25, 2019
Collaborator
La0
left a comment
There was a problem hiding this comment.
You break the self.pulse.run() later call when not using the publication
Collaborator
Author
Oops, I forgot about that one... |
La0
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't consume messages when publication is disabled:
code-review/events/code_review_events/workflow.py
Lines 356 to 362 in 02d31ad