Skip to content

events: Don't register for pulse notifications when publication is disabled#262

Merged
La0 merged 3 commits intomozilla:masterfrom
marco-c:publish_false
Nov 25, 2019
Merged

events: Don't register for pulse notifications when publication is disabled#262
La0 merged 3 commits intomozilla:masterfrom
marco-c:publish_false

Conversation

@marco-c
Copy link
Copy Markdown
Collaborator

@marco-c marco-c commented Nov 25, 2019

Since we don't consume messages when publication is disabled:

# Publish results on Phabricator
if self.workflow.publish:
consumers.append(
self.bus.run(self.workflow.publish_results, QUEUE_PHABRICATOR_RESULTS)
)
consumers.append(self.bus.run(self.workflow.parse_pulse, QUEUE_PULSE))
.

@marco-c marco-c requested a review from La0 November 25, 2019 09:58
Copy link
Copy Markdown
Collaborator

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You break the self.pulse.run() later call when not using the publication

@marco-c
Copy link
Copy Markdown
Collaborator Author

marco-c commented Nov 25, 2019

You break the self.pulse.run() later call when not using the publication

Oops, I forgot about that one...

@La0 La0 merged commit 3221e3c into mozilla:master Nov 25, 2019
@marco-c marco-c deleted the publish_false branch January 13, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants