Common Phabricator unit & lint results#417
Merged
La0 merged 4 commits intomozilla:masterfrom Jan 8, 2020
Merged
Conversation
La0
commented
Jan 8, 2020
| "toolchain", | ||
| "--from-build", | ||
| "linux64-infer", | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
A useless const from an old time 😏
Merged
marco-c
approved these changes
Jan 8, 2020
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
Nice cleanup. This probably fixes one of the cleanup follow-up issues that we have filed over time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep work for #364
Every issue needed to implement
as_phabricator_lint&as_phabricator_unitresult. But we have re-organized the Issue inner data earlier, allowing us to have a unique implementation for these methods.The unit results are only used by Coverity (for build errors), but every Issue will be able to post a lint result now (for an error outside the patch).
The good news is that the payload do not change a lot (even if they were not used until now) as you can see in the unit tests.