Skip to content

Sort issue stats by detected or publishable #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
La0 merged 1 commit into from
Jan 10, 2020
Merged

Sort issue stats by detected or publishable #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions frontend/src/Stats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ export default {
repository: null,
check: null,

// Sort by a column
sortColumn: 'total',

// Options for chartist
chartOptions: {
height: 300,
Expand Down Expand Up @@ -46,6 +49,10 @@ export default {
analyzer: this.analyzer,
check: this.check
})
},
sort_by (column) {
// Store new sort column
this.$set(this, 'sortColumn', column)
}
},
computed: {
Expand All @@ -54,8 +61,8 @@ export default {
return null
}

// Sort by detected
let stats = this.stats.sort((x, y) => x.detected > y.detected)
// Sort by specified column
let stats = this.stats.sort((x, y) => x[this.sortColumn] < y[this.sortColumn])

// Apply filters
if (this.repository !== null) {
Expand Down Expand Up @@ -124,8 +131,12 @@ export default {
<th>
<Choice :choices="checks" name="check" v-on:new-choice="use_filter('check', $event)"/>
</th>
<th>Detected</th>
<th>Publishable</th>
<th>
<button class="button is-info" v-on:click="sort_by('total')" :disabled="sortColumn == 'total'">Detected</button>
</th>
<th>
<button class="button is-info" v-on:click="sort_by('publishable')" :disabled="sortColumn == 'publishable'">Publishable</button>
</th>
</tr>
</thead>
<tbody>
Expand Down