Skip to content

bot: separate errors agains the linting issues#82

Merged
La0 merged 4 commits intomozilla:masterfrom
abpostelnicu:publish_errors
Aug 20, 2019
Merged

bot: separate errors agains the linting issues#82
La0 merged 4 commits intomozilla:masterfrom
abpostelnicu:publish_errors

Conversation

@abpostelnicu
Copy link
Copy Markdown
Contributor

This is a followup for #69 where we separate the build errors vs linting issues.

@abpostelnicu abpostelnicu requested a review from La0 August 19, 2019 08:01
@abpostelnicu abpostelnicu self-assigned this Aug 19, 2019
@abpostelnicu abpostelnicu added the bot Code review bot label Aug 19, 2019
Comment thread bot/code_review_bot/report/phabricator.py
Comment thread bot/code_review_bot/report/phabricator.py Outdated
Comment thread bot/code_review_bot/report/phabricator.py
Comment thread bot/code_review_bot/report/phabricator.py
Comment thread bot/tests/test_reporter_phabricator.py
@abpostelnicu abpostelnicu force-pushed the publish_errors branch 2 times, most recently from 1d5d2e6 to 097d50d Compare August 19, 2019 10:37
Copy link
Copy Markdown
Collaborator

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally on our test revision & successfully posted build errors

@La0 La0 merged commit 82e2439 into mozilla:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot Code review bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants