Add events workflow#90
Merged
La0 merged 23 commits intomozilla:masterfrom Sep 10, 2019
Merged
Conversation
La0
force-pushed
the
events
branch
5 times, most recently
from
30ce4ad to
7a45e74
Compare
La0
force-pushed
the
events
branch
2 times, most recently
from
7be15c6 to
079bd97
Compare
added 11 commits
September 9, 2019 14:37
Collaborator
Author
|
This is now running OK on testing, replacing the release-services instance as https://eventlistener.testing.moz.tools/ This demo build on phab-dev was processed by this new instance |
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
reviewed
Sep 9, 2019
marco-c
approved these changes
Sep 9, 2019
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
I'd make cli only handle cli options and move all the "architecture initialization" stuff to "workflow.py" to have everything in a single place (so it's easier to see the overall architecture by reading the code), but I don't mind the way it is now.
LGTM!
Co-Authored-By: Marco <mcastelluccio@mozilla.com>
Co-Authored-By: Marco <mcastelluccio@mozilla.com>
Co-Authored-By: Marco <mcastelluccio@mozilla.com>
Co-Authored-By: Marco <mcastelluccio@mozilla.com>
Collaborator
Author
|
Fixed all the comments + moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from release-services