Skip to content

Add lando warnings support#975

Merged
abpostelnicu merged 1 commit intomozilla:masterfrom
abpostelnicu:lando
Sep 17, 2021
Merged

Add lando warnings support#975
abpostelnicu merged 1 commit intomozilla:masterfrom
abpostelnicu:lando

Conversation

@abpostelnicu
Copy link
Copy Markdown
Contributor

@abpostelnicu abpostelnicu commented Sep 10, 2021 •
edited
Loading

With mozilla-conduit/lando-api#172 we have support in lando to send warnings.
We are going to send two warnings for each diff for each revision:

  • Once the revision has been updated/created an initial message will be send indicating the user that there are linters running:"Review time linters are still running. Are you sure you want to continue?"
  • Just as the review bot finishes posting issues in phab we send the 2nd message with the issues or if there aren't any we clear previous send message.

@abpostelnicu abpostelnicu self-assigned this Sep 10, 2021
@abpostelnicu abpostelnicu force-pushed the lando branch 6 times, most recently from d288017 to ba18936 Compare September 11, 2021 15:39
@abpostelnicu abpostelnicu changed the title events: add warning event to lando when linters are started Add lando warnings support Sep 11, 2021
@abpostelnicu abpostelnicu force-pushed the lando branch 3 times, most recently from 9154ac4 to 0d08c7c Compare September 12, 2021 14:04
@abpostelnicu
Copy link
Copy Markdown
Contributor Author

abpostelnicu commented Sep 12, 2021

This has been thoroughly tested on testing and it works like a charm. Unfortunately repo mozilla-central is not compatible with the new feature from lando and the warning messages cannot be displayed in the UI bu they appear in the backend.

@abpostelnicu
Copy link
Copy Markdown
Contributor Author

abpostelnicu commented Sep 12, 2021

@zzzeid do you think we can add mozilla-central to be compatible on lando testing with the new feature set?

@abpostelnicu abpostelnicu added bot Code review bot events Event listener tools Common Python tools labels Sep 12, 2021
@abpostelnicu abpostelnicu marked this pull request as ready for review September 13, 2021 08:24
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread tools/code_review_tools/lando.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread tools/code_review_tools/lando.py Outdated
marco-c
marco-c reviewed Sep 13, 2021
View reviewed changes
Comment thread events/code_review_events/workflow.py Outdated
@marco-c
Copy link
Copy Markdown
Collaborator

marco-c commented Sep 13, 2021

Could you write some tests for this feature in bot and events?

marco-c
marco-c reviewed Sep 15, 2021
View reviewed changes
Comment thread bot/code_review_bot/report/lando.py Outdated
marco-c
marco-c reviewed Sep 15, 2021
View reviewed changes
Comment thread bot/code_review_bot/report/lando.py Outdated
marco-c
marco-c reviewed Sep 15, 2021
View reviewed changes
Comment thread bot/code_review_bot/workflow.py Outdated
marco-c
marco-c reviewed Sep 15, 2021
View reviewed changes
Comment thread events/code_review_events/workflow.py Outdated
@marco-c
Copy link
Copy Markdown
Collaborator

marco-c commented Sep 15, 2021

Looks good overall, but we need to add some tests to both bot and events

@abpostelnicu abpostelnicu force-pushed the lando branch 2 times, most recently from 61b9582 to 6d9a6dc Compare September 17, 2021 11:41
marco-c
marco-c reviewed Sep 17, 2021
View reviewed changes
Comment thread bot/code_review_bot/report/lando.py Outdated
marco-c
marco-c reviewed Sep 17, 2021
View reviewed changes
Comment thread bot/tests/test_lando.py
marco-c
marco-c reviewed Sep 17, 2021
View reviewed changes
Comment thread events/code_review_events/workflow.py Outdated
marco-c
marco-c reviewed Sep 17, 2021
View reviewed changes
Comment thread events/code_review_events/workflow.py Outdated
marco-c
marco-c reviewed Sep 17, 2021
View reviewed changes
Comment thread events/tests/test_workflow.py Outdated
@abpostelnicu abpostelnicu merged commit 118b072 into mozilla:master Sep 17, 2021
@abpostelnicu abpostelnicu deleted the lando branch September 17, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

@abpostelnicu abpostelnicu

Labels

bot Code review bot events Event listener tools Common Python tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abpostelnicu @marco-c