Skip to content

bot: when a generic bot failure occurs also report it in phabricator.#986

Merged
abpostelnicu merged 2 commits intomozilla:masterfrom
abpostelnicu:dev
Sep 23, 2021
Merged

bot: when a generic bot failure occurs also report it in phabricator.#986
abpostelnicu merged 2 commits intomozilla:masterfrom
abpostelnicu:dev

Conversation

@abpostelnicu
Copy link
Copy Markdown
Contributor

@abpostelnicu abpostelnicu commented Sep 23, 2021

We are using requests in the backend module, so track the requests.exceptions.HTTPError and update phabricator.
This fixes #984.

@abpostelnicu abpostelnicu self-assigned this Sep 23, 2021
Comment thread bot/code_review_bot/cli.py Outdated
@abpostelnicu abpostelnicu changed the title bot: treat Http exception in a separate way. bot: when a generic bot failure occurs also report it in phabricator. Sep 23, 2021
@abpostelnicu abpostelnicu marked this pull request as ready for review September 23, 2021 12:08
Comment thread bot/code_review_bot/cli.py Outdated
Comment thread bot/code_review_bot/cli.py
Comment thread bot/code_review_bot/cli.py Outdated
Comment thread bot/code_review_bot/cli.py
Comment thread bot/code_review_bot/cli.py
@abpostelnicu abpostelnicu merged commit 9df3342 into mozilla:master Sep 23, 2021
@abpostelnicu abpostelnicu deleted the dev branch September 23, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When failing during workflow.run, post a generic failure like we do during events

2 participants