Skip to content

bot: do not throw exceptions when backend fails.#987

Merged
abpostelnicu merged 2 commits intomozilla:masterfrom
abpostelnicu:backend
Oct 5, 2021
Merged

bot: do not throw exceptions when backend fails.#987
abpostelnicu merged 2 commits intomozilla:masterfrom
abpostelnicu:backend

Conversation

@abpostelnicu
Copy link
Copy Markdown
Contributor

@abpostelnicu abpostelnicu commented Sep 23, 2021

This fixes #983

@abpostelnicu abpostelnicu self-assigned this Sep 23, 2021
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
Comment thread bot/code_review_bot/backend.py Outdated
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
Comment thread bot/code_review_bot/backend.py Outdated
@abpostelnicu abpostelnicu force-pushed the backend branch 2 times, most recently from 3feb49c to 8efbbd1 Compare September 23, 2021 15:32
@abpostelnicu abpostelnicu marked this pull request as ready for review September 23, 2021 15:32
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
Comment thread bot/code_review_bot/backend.py Outdated
marco-c
marco-c previously approved these changes Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a test to ensure that, when the backend fails, we are still able to publish?

If you prefer to do it in a follow-up, please file an issue so we don't forget.

@abpostelnicu
Copy link
Copy Markdown
Contributor Author

abpostelnicu commented Sep 23, 2021

Could you write a test to ensure that, when the backend fails, we are still able to publish?

If you prefer to do it in a follow-up, please file an issue so we don't forget.

No, I would prefer to do it now, to know that we have this covered!

@abpostelnicu abpostelnicu force-pushed the backend branch 2 times, most recently from 1ab33ad to 9fea098 Compare September 23, 2021 16:13
marco-c
marco-c reviewed Sep 23, 2021
View reviewed changes
Comment thread bot/tests/test_backend.py Outdated
]


def test_publication_failures_total(
Copy link
Copy Markdown
Collaborator

@marco-c marco-c Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a test which runs the run function of the workflow and, even if the backend fails, it publishes some issues

@abpostelnicu
Copy link
Copy Markdown
Contributor Author

abpostelnicu commented Oct 5, 2021

@marco-c I wanna do this in this release wdyt if we add the tests as a followup?

@marco-c
Copy link
Copy Markdown
Collaborator

marco-c commented Oct 5, 2021

@marco-c I wanna do this in this release wdyt if we add the tests as a followup?

WFM, can you file an issue for that?

@abpostelnicu abpostelnicu requested a review from marco-c October 5, 2021 09:29
marco-c
marco-c approved these changes Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please file a follow-up issue about adding tests.

@abpostelnicu abpostelnicu merged commit 2f36401 into mozilla:master Oct 5, 2021
@abpostelnicu abpostelnicu mentioned this pull request Oct 5, 2021
Open
@abpostelnicu abpostelnicu deleted the backend branch October 8, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

@abpostelnicu abpostelnicu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignore exceptions from the backend

2 participants

@abpostelnicu @marco-c