crlite-signoff: stop enforcing verification_domains.txt check.#385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification domains check is supposed to stop us from publishing a filter that would block access to critical infrastructure. It fetches certificates from a list of TLS servers and checks that none of them are marked as revoked. The check fails closed, so a temporary outage at one of the servers or a failure to fetch, say, the CCADB intermediate certificate list causes us to halt filter publication.
The verification domains check was plausibly useful when our CRLite implementation suffered from false positives. Now it just has a tendency to halt publication. If we were to ever publish a filter that blocked access to critical Firefox infrastructure, we would simply rotate the certificate on the affected server and/or publish new filters.