Feature: Set "Hostname" #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2017 12:11
…name of the machine. Switching branch to a testing branch.
tristanthomas
suggested changes
Dec 15, 2017
repo/set-computername.sh
Outdated
|
|
||
| scutil --set LocalHostName $hostname | ||
| scutil --set ComputerName $hostname | ||
| dscacheutil -flushcache |
Contributor
There was a problem hiding this comment.
We can leave out the dscacheutil command.
@tristanthomas noticed that I was using dscacheutil to flush DNS, but that's not really necessary in this case since we're not actually setting the hostname and we reboot at the end of the build. +1, we shouldn't have stuff we know is unnecessary in the build.
tristanthomas
approved these changes
Dec 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #51 - Hostname is a bit of a misnomer, since we're not actually setting the hostname anywhere. A more accurate feature description would be "Set ComputerName and LocalHostName" but that's annoying.
We added the set-computername.sh script early in the build so that software like Crashplan will have access to the correct hostname, in case it matters.
Build has been tested in a development branch, ready to push to master.