This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Fix S to allow for other SearchResults classes#58
Closed
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:search-results
Closed
Fix S to allow for other SearchResults classes#58willkg wants to merge 1 commit intomozilla:masterfrom willkg:search-results
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:search-results
Conversation
If you wanted to write your own SearchResults class and use it, you'd have to override non-trivial and private innards of S. This makes that possible. Also, I changed decorate_with_metadata so that it's not marked as "private". That's a helpful function.
Member
Author
|
My big use case is that I want to create a SearchResults class that holds a list of FauxObject classes which have the data that ES returns for the result, plus the metadata (highlight, score, etc), plus methods that help me use that. |
Member
Author
|
@robhudson Can you take a look at this when you have a chance? |
Member
Author
|
I'm going to nix this. We've got a better idea, so I'll work on that instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you wanted to write your own SearchResults class and use it,
you'd have to override non-trivial and private innards of S.
This makes that possible.
Also, I changed decorate_with_metadata so that it's not marked as
"private". That's a helpful function.
r?