Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Fix S to allow for other SearchResults classes#58

Closed
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:search-results
Closed

Fix S to allow for other SearchResults classes#58
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:search-results

Conversation

@willkg
Copy link
Member

@willkg willkg commented Aug 23, 2012

If you wanted to write your own SearchResults class and use it,
you'd have to override non-trivial and private innards of S.

This makes that possible.

Also, I changed decorate_with_metadata so that it's not marked as
"private". That's a helpful function.

r?

If you wanted to write your own SearchResults class and use it,
you'd have to override non-trivial and private innards of S.

This makes that possible.

Also, I changed decorate_with_metadata so that it's not marked as
"private". That's a helpful function.
@willkg
Copy link
Member Author

willkg commented Aug 23, 2012

My big use case is that I want to create a SearchResults class that holds a list of FauxObject classes which have the data that ES returns for the result, plus the metadata (highlight, score, etc), plus methods that help me use that.

@willkg
Copy link
Member Author

willkg commented Aug 23, 2012

@robhudson Can you take a look at this when you have a chance?

@willkg
Copy link
Member Author

willkg commented Aug 28, 2012

I'm going to nix this. We've got a better idea, so I'll work on that instead.

@willkg willkg closed this Aug 28, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant