Bug 2036167 - Enterprise: Access Connector testing#825
Conversation
lissyx
added
bug
|
|
||
| def run_load_page_with_access_connector(self): | ||
| try: | ||
| self.open_tab_child("https://support.mozilla.org/") |
There was a problem hiding this comment.
Is there value in checking a non matching URL loads properly?
There was a problem hiding this comment.
I think there is value in checking this since we currently configure it to operate in "inclusion mode" - checking both paths will make sure it's operating properly. If we only check one, we can miss cases of misconfiguration, inclusion mode breaking, or issues with the channel filtering/pattern matching.
There was a problem hiding this comment.
A good example is http://support.mozilla.org since the pattern in the policy is specific to https. Can also add https://example.com for one that's entirely different.
There was a problem hiding this comment.
@lissyx the PR is looking good - just need to add the "non-matching url when AccessConnector is enabled" case to make sure the inclusion mode is working as expected.
There was a problem hiding this comment.
@jporter-dev I've added tests to /ping of the console
There was a problem hiding this comment.
http://support.mozilla.org is unfortunately redirecting to https so ...
There was a problem hiding this comment.
Ah didn't catch that addition, that should cover it then!
lissyx
force-pushed
the
enterprise-bug2036167_access_connectors_tests
branch
from
85da431 to
6221221
Compare
|
|
||
| def run_load_page_with_access_connector(self): | ||
| try: | ||
| self.open_tab_child("https://support.mozilla.org/") |
There was a problem hiding this comment.
I think there is value in checking this since we currently configure it to operate in "inclusion mode" - checking both paths will make sure it's operating properly. If we only check one, we can miss cases of misconfiguration, inclusion mode breaking, or issues with the channel filtering/pattern matching.
lissyx
force-pushed
the
enterprise-bug2036167_access_connectors_tests
branch
3 times, most recently
from
492b46e to
3d055bd
Compare
Provide basic testing of access connector from policies pushed by the console, either being set enabled by default (from console) or disabled by default (from console). Coverage ensures prefs and set at expected values, and locked when applied and correctly unlocked and reset after. Also try to load data with the policy applied and verify there is a proxy error because no proxy is really setup to handle the connections.
lissyx
force-pushed
the
enterprise-bug2036167_access_connectors_tests
branch
from
3d055bd to
5f38e85
Compare
3 participants
Provide basic testing of access connector from policies pushed by the console, either being set enabled by default (from console) or disabled by default (from console). Coverage ensures prefs and set at expected values, and locked when applied and correctly unlocked and reset after.
Also try to load data with the policy applied and verify there is a proxy error because no proxy is really setup to handle the connections.
Bugzilla: Bug-2036167
Testing