feat(UI): Add Tooltip to draft/preview card on the new homepage.#13175
Merged
feat(UI): Add Tooltip to draft/preview card on the new homepage.#13175
Conversation
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
yashikakhurana
requested changes
Jul 31, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @b4handjr 🎉 it would be great if you can move that text to a constant file and then refer it here
| <i class="fa-regular fa-circle-question" | ||
| data-bs-toggle="tooltip" | ||
| data-bs-placement="top" | ||
| data-bs-title="This is anything that you own or are subscribed to follow – which are in Draft or Preview states. Go to the link to check the message for the next actions needed."></i> |
Contributor
There was a problem hiding this comment.
for this text, you can add in here as a constant, this refers to our UI constants, refer to this PR here https://github.com/mozilla/experimenter/pull/13117/files and pass this in a context, you can also create home page as key and under that put links and tooltips
yashikakhurana
approved these changes
Jul 31, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
perfect, thank you @b4handjr 🎉 🎉
| draft_or_preview_experiments, 4 | ||
| ).get_page(draft_page) | ||
| context["links"] = NimbusUIConstants.HOME_PAGE_LINKS | ||
| context["tooltips"] = NimbusUIConstants.HOME_PAGE_TOOLTIPS |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
This is anything that you own or are subscribed to follow – which are in Draft or Preview states. Go to the link to check the message for the next actions needed.Fixes #13174