bug(nimbus): Improve performance of NimbusExperiment.computed_enrollment_days#14075
Merged
freshstrangemusic merged 1 commit intomainfrom Nov 26, 2025
Merged
bug(nimbus): Improve performance of NimbusExperiment.computed_enrollment_days#14075freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart and
yashikakhurana
as code owners
yashikakhurana
approved these changes
Nov 26, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Nice improvement, thanks @freshstrangemusic
…ent_days Because: - NimbusExperiment.computed_enrollment_days processes several change logs in memory this commit: - moves all the sorting and filtering to the SQL query; and - limits the amount of data returned to Python to only the needful. Fixes #14074
freshstrangemusic
force-pushed
the
push-mlzsvlrkvvzm
branch
from
a32e8ed to
bcbeaa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #14074