chore(nimbus): always use transaction.atomic for form saves#14189
Merged
jaredlockhart merged 1 commit intomainfrom Dec 15, 2025
Merged
chore(nimbus): always use transaction.atomic for form saves#14189jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
Becuase * We recently saw races and collisions between forms and celery tasks saving the same instances * We can wrap both in transaction.atomic to ensure they occur separately This commit * Wraps all form saves in transaction.atomic fixes #14188
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
yashikakhurana
approved these changes
Dec 15, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Totally, I am just wondering if there might be some easy way instead of adding it on all save 🤔, but totally works. Thank you @jaredlockhart
Collaborator
Author
|
Yeah @yashikakhurana afaik this is the only way. I mean without doing some kind of metaclass hackery, but I generally try to avoid that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #14188