Skip to content

feat(nimbus): Add cancel emoji if requests get cancelled#14853

Merged
yashikakhurana merged 4 commits intomainfrom
14840
Mar 9, 2026
Merged

feat(nimbus): Add cancel emoji if requests get cancelled#14853
yashikakhurana merged 4 commits intomainfrom
14840

Conversation

@yashikakhurana
Copy link
Copy Markdown
Contributor

Because

  • Users can cancel launch requests and resubmit them. However, we don’t have any indication in Slack messages that a request has already been cancelled, so reviewers aren’t aware of this.

This commit

  • Adds the cancel emoji to the requests if the request is already cancelled
  • This also fixes to look for the latest request for the emoji to add as we have seen it tried to add emoji to the old requests

Fixes #14840 #14838

Comment thread experimenter/experimenter/slack/notification.py Outdated
Comment thread experimenter/experimenter/nimbus_ui/forms.py Outdated
@yashikakhurana yashikakhurana dismissed jaredlockhart’s stale review March 5, 2026 22:37

using single method now

Copy link
Copy Markdown
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should have an enum somewhere of all the slack emojis we want to send and use but otherwise very nice good test coverage, very clear 🙏

Comment thread experimenter/experimenter/nimbus_ui/forms.py Outdated
Copy link
Copy Markdown
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this reads much better now ty @yashikakhurana 🎉 🎉 🎉 🎉

@yashikakhurana yashikakhurana added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 954ebfa Mar 9, 2026
18 checks passed
@yashikakhurana yashikakhurana deleted the 14840 branch March 9, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants