Skip to content

feat(nimbus): Add enrollment alert data GCS reader and Celery fetch task#15035

Merged
yashikakhurana merged 6 commits intomainfrom
15024
Mar 30, 2026
Merged

feat(nimbus): Add enrollment alert data GCS reader and Celery fetch task#15035
yashikakhurana merged 6 commits intomainfrom
15024

Conversation

@yashikakhurana
Copy link
Copy Markdown
Contributor

@yashikakhurana yashikakhurana commented Mar 25, 2026 •
edited
Loading

Because

  • Now we have the enrollment count JSON available that we can use to set the monitoring data for each experiment, which can be used further to alert users for the thresholds and SRM.

This commit

  • Fetches the JSON data, parses and set it to the experiment monitoring_data field

Fixes #15024 #15036

@yashikakhurana yashikakhurana marked this pull request as ready for review March 25, 2026 17:19
@yashikakhurana yashikakhurana linked an issue Mar 25, 2026 that may be closed by this pull request
Experimenter- Add enrollment alert thresholds and message templates #15036
Closed
7 tasks
mikewilli
mikewilli reviewed Mar 26, 2026
View reviewed changes
Comment thread experimenter/experimenter/settings.py Outdated
Comment thread experimenter/experimenter/settings.py
Comment thread experimenter/experimenter/slack/constants.py
Comment thread experimenter/experimenter/jetstream/client.py Outdated
Comment thread experimenter/experimenter/jetstream/tasks.py Outdated
Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py
Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py Outdated
Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py
Comment thread experimenter/experimenter/jetstream/tasks.py Outdated
Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py Outdated
yashikakhurana and others added 2 commits March 26, 2026 12:59
@yashikakhurana @mikewilli
Update experimenter/experimenter/jetstream/tasks.py
1b9b930 
Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
fix(nimbus): Requested changes
d9f102e
@yashikakhurana
Copy link
Copy Markdown
Contributor Author

yashikakhurana commented Mar 27, 2026

Thank you for the review @mikewilli , hopefully I am not missing any changes 🤞 :D

mikewilli
mikewilli approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc couple things but they're pretty small so I'll approve

Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py Outdated
Comment thread experimenter/experimenter/jetstream/tests/test_tasks.py Outdated
@yashikakhurana yashikakhurana added this pull request to the merge queue Mar 30, 2026
@yashikakhurana yashikakhurana removed a link to an issue Mar 30, 2026
Experimenter- Add enrollment alert thresholds and message templates #15036
Closed
7 tasks
Merged via the queue into main with commit 89e94ba Mar 30, 2026
31 checks passed
@yashikakhurana yashikakhurana deleted the 15024 branch March 30, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikewilli mikewilli mikewilli approved these changes

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@relud relud Awaiting requested review from relud

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add enrollment alert data GCS reader and Celery fetch task

2 participants

@yashikakhurana @mikewilli