feat(nimbus): Enforce experiment key in messaging messages#15211
Open
freshstrangemusic wants to merge 1 commit intomainfrom
Open
feat(nimbus): Enforce experiment key in messaging messages#15211freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic wants to merge 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
freshstrangemusic
force-pushed
the
freshstrangemusic/push-nuwywmlmrozn
branch
from
6efe3c4 to
63bb5e6
Compare
Because:
- iOS and Fenix have a "messaging" feature with a special "experiment"
key in the message;
- this key needs to have a value of "{experiment}", but is optional; and
- if this key is not present, telemetry may not be submitted correctly
this commit:
- enforces that the key exists and is the correct value.
Fixes #15210
freshstrangemusic
force-pushed
the
freshstrangemusic/push-nuwywmlmrozn
branch
from
63bb5e6 to
7763d39
Compare
jaredlockhart
approved these changes
Apr 13, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Oh yeah I remember this, it was the lesser evil of the possible approaches. I wonder why we didn't add this validation a while ago? Was there ever a case where you didn't want to include the placeholder? Anyways thanks for adding @freshstrangemusic 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #15210