feat(nimbus): Should skip same day alert for unenrollments#15284
Merged
yashikakhurana merged 2 commits intomainfrom Apr 15, 2026
Merged
feat(nimbus): Should skip same day alert for unenrollments#15284yashikakhurana merged 2 commits intomainfrom
yashikakhurana merged 2 commits intomainfrom
Conversation
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
jaredlockhart
previously requested changes
Apr 15, 2026
|
|
||
| if experiment.start_date and ( | ||
| datetime.date.today() - experiment.start_date | ||
| ) < datetime.timedelta(days=1): |
Collaborator
There was a problem hiding this comment.
Maybe that 1 should be a constant somewhere so we clearly know what it's for and what it's doing.
Contributor
Author
There was a problem hiding this comment.
yup good idea
jaredlockhart
approved these changes
Apr 15, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Yeah that definitely reads better awesome ty @yashikakhurana 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #15221