fix(nimbus): skip data points with None bounds in get_max_metric_value#15517
Merged
Conversation
Fixes mozilla#15396 Signed-off-by: SAY-5 <say.apm35@gmail.com>
moibra05
approved these changes
May 5, 2026
Contributor
moibra05
left a comment
There was a problem hiding this comment.
thanks for taking a look at this! changes look simple and enough to fix this issue, nice work 👍
yashikakhurana
requested changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Hey @SAY-5 thank you for your contribution, I noticed one of the test case is failing
FAILED experimenter/jetstream/tests/test_results_manager.py::TestExperimentResultsManager::test_get_max_metric_value_2 - AssertionError: 0 != 0.7
would you be able to take a look and fix that please 🙏
Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
Contributor
Author
|
Fixed the failing test. |
yashikakhurana
approved these changes
May 6, 2026
Contributor
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @SAY-5 looks good 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
relative_upliftresults can have explicitnull(or missing)lower/upperwhile still being a non-empty dict (e.g. onlypointis set). The existingif not data_point: continueguard treats these as truthy and proceeds, thenabs(None)raisesTypeError: bad operand type for abs(): 'NoneType'(Sentry EXPERIMENTER-PROD-16X).This commit
Nonebefore callingabs()inResultsManager.get_max_metric_value.Nonelower/upper alongside a sibling branch with valid bounds, asserting the valid bounds still drive the max.Fixes #15396