fixes #9201 bug(nimbus): Do not use negation in targeting expressions#9204
Merged
freshstrangemusic merged 1 commit intomainfrom Aug 2, 2023
Merged
Conversation
Because: - the JEXL evaluator in mobile does not support negation (`!expr`) this commit: - updates the generated exclusion targeting not to use negation and use comparison instead.
freshstrangemusic
requested review from
eliserichards,
jaredlockhart and
yashikakhurana
as code owners
jeddai
approved these changes
Aug 2, 2023
Member
jeddai
left a comment
jeddai
left a comment
There was a problem hiding this comment.
This looks good, should be good to merge assuming all the tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
!expr)this commit: