Skip to content

Bug 1146611 - Prompt for opening anything that can be opened#303

Merged
wesj merged 1 commit intomozilla-mobile:masterfrom
wesj:loadUrls
Apr 10, 2015
Merged

Bug 1146611 - Prompt for opening anything that can be opened#303
wesj merged 1 commit intomozilla-mobile:masterfrom
wesj:loadUrls

Conversation

@wesj
Copy link
Copy Markdown

@wesj wesj commented Apr 3, 2015

I think we should probably just do something like this (and then get less restrictive from here). i.e. If there's something installed that can open the url, Prompt the user to open with it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this. I think we should follow what Safari does for at least a few specific url schemes:

  • tel shows an alert: +1234567890 Cancel / Call
  • sms opens the SMS app directly (no harm because nothing happens until you confirm there)
  • facetime shows an alert: myapple@id.com Cancel / FaceTime
  • There is also a special case for App Store links (there are a ton of special links) that we should handle in a non-generic way I think?

For other schemes i think it is good to show something generic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine doing those things. Android has a whitelist for things to not prompt for (including SMS). I'm a little nervous about the app store links (i.e. Its a lot easier to get back to Safari from the store than it is to get back to Firefox), and we shouldn't need them (i.e. the App Store redirects to itms:// urls, but apparently they do it incorrectly sometimes).

I'll file some follow ups for this stuff though. This gets us to the point where everything should work (except the evil app store links that aren't using itms://).

wesj pushed a commit that referenced this pull request Apr 10, 2015
Bug 1146611 - Prompt for opening anything that can be opened
@wesj wesj merged commit 80c8393 into mozilla-mobile:master Apr 10, 2015
@wesj wesj deleted the loadUrls branch April 10, 2015 20:49
ecotopian referenced this pull request in ecosia/ios-browser Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants