Bug 1175134 - Present the settings in a modal view on iPad#610
Merged
st3fan merged 3 commits intomozilla-mobile:masterfrom Jun 19, 2015
Merged
Bug 1175134 - Present the settings in a modal view on iPad#610st3fan merged 3 commits intomozilla-mobile:masterfrom
st3fan merged 3 commits intomozilla-mobile:masterfrom
Conversation
jaredStef
force-pushed
the
iPadModalSettings
branch
from
154343e to
6bb7481
Compare
Contributor
|
@BIGXmac This looks good. Can you also present the settings in a similar way when you hit the 'Sign In to Firefox' button on the Intro page? From there it opens the settings in full screen. |
st3fan
changed the title
Contributor
Author
There was a problem hiding this comment.
Not sure why this was commited
Contributor
|
LGTM, thanks! |
st3fan
added a commit
that referenced
this pull request
Jun 19, 2015
Bug 1175134 - Present the settings in a modal view on iPad
ecotopian
referenced
this pull request
in ecosia/ios-browser
Mar 1, 2022
* Fix commitish exists check * Updated Changelog * Updated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iPad Settings app now modals in the form of a sheet.
https://bugzilla.mozilla.org/show_bug.cgi?id=1175134