get color values for all bgs #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: Link
Description of Code / Doc Changes
Process Changes Required
None
Screenshots or Explanations
The current AboutAddons.activate_theme contains a
perform_assertcheck to ensure that the theme was applied successfully. We need to not do that so we can use our "close enough" method.Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
I think it would be worthwhile to consider removing the theme color assertion in
AboutAddons.activate_theme()and update all relevant tests.Workflow Checklist
Thank you!