Skip to content

Conversation

@sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Oct 3, 2025

Relevant Links

Bugzilla: 1990605
TestRail: S2103

Description of Code / Doc Changes

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@sv-hyacoub sv-hyacoub marked this pull request as draft October 3, 2025 13:39
@sv-hyacoub sv-hyacoub marked this pull request as ready for review October 13, 2025 11:30
@sv-hyacoub sv-hyacoub changed the title [Draft] Hani/ Refactor tabs batch 2 Hani/ Refactor tabs batch 2 Oct 13, 2025
Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@sv-hyacoub sv-hyacoub merged commit 63397ea into main Oct 14, 2025
26 of 27 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/refactor-tabs-batch2 branch October 14, 2025 12:49
ben-c-at-moz added a commit that referenced this pull request Oct 15, 2025
* stabilize autofill tests

* add selectors

* Anca/ Stabilization on allow audio-video (#834)

* Stabilization on allow audio-video

* Remove unused imports

* Skip test on Win with a clear reason

* Hani/ Refactor tabs batch 2 (#824)

* Refactor tabs batch 2

* Skip a test

* fix test open new via hyperlink

* replace more-information with learn-more

---------

Co-authored-by: Hani Yacoub <hani.yacoub@svadmins-MBP.lan>

* Update example.com hyperlink (#835)

Fixes several tests that access the example.com page hyperlink

* Vs/Add tests for seach modes persistance with @bing  (#838)

* stabilize autofill tests

* add selectors

* Tracy/ Skip new failing tests (#839)

* stabilize autofill tests

* add selectors

* modify one selector

* check running version is actually correct

* attempt to force CI machine to see payment/address buttons in prefs

* get loc of installed win fx

* just test the version for now

* test quotes for exec

* test quotes for exec

* test win path again

* test win path again

* test win path again

* test win path again

* test win path again

* test win path again

* add log to see binary location

* see full capabilities object

* see full capabilities object

* remove lines

* test win path again, sleep

* test win path again, sleep

* test win path again

* test win path again

* test win path again

* try to force a write of fx location

* try to force a write of fx location

* attempt to disable Se driver mgmt

* attempt to disable Se driver mgmt

* attempt to disable Se driver mgmt

* attempt to run again

* remove debug

* remove debug

---------

Co-authored-by: soncuteanca <141660365+soncuteanca@users.noreply.github.com>
Co-authored-by: Hani Yacoub <hyacoub@mozilla.com>
Co-authored-by: Hani Yacoub <hani.yacoub@svadmins-MBP.lan>
Co-authored-by: Tracy <twalker@mozilla.com>
Co-authored-by: vsangereanMOZ <vsangerean@mozilla.com>
Co-authored-by: Philimon Derib Ayalew <philimonset@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants