Skip to content

Conversation

@ben-c-at-moz
Copy link
Collaborator

Relevant Links

Bugzilla

Description of Code / Doc Changes

  • Add new necessary prefs in form_autofill conftest
  • change selectors in AboutPrefs
  • change AboutPrefs helpers to use new selectors properly
  • lint

Process Changes Required

Mark the relevant boxes:

  • Changes or creates a BOM/POM (name the object model): AboutPrefs

Screenshots or Explanations

I think just some prefs and selectors changed. I'm surprised this passed on Windows in Scheduled Beta.

Comments or Future Work

We desperately need to refactor the Form Autofill / AboutPrefs POMs

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Tracy-Walker
Tracy-Walker previously approved these changes Oct 15, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@ben-c-at-moz ben-c-at-moz dismissed Tracy-Walker’s stale review October 15, 2025 17:13

The merge-base changed after approval.

@ben-c-at-moz ben-c-at-moz merged commit 5b5499a into main Oct 15, 2025
21 of 23 checks passed
@ben-c-at-moz ben-c-at-moz deleted the ben/stabilize-autofill branch October 15, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants