Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions SELECTOR_INFO.md
Original file line number Diff line number Diff line change
Expand Up @@ -2611,6 +2611,13 @@ Path to .json: modules/data/login_autofill.components.json
Selector Name: bsky-credentials
Selector Data: ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']"
Description: Autocomplete dropdown is toggled for focused login fields on facebook page load
Location: bsky page load
Path to .json: modules/data/login_autofill.components.json
```
```
Selector Name: facebook-credentials
Selector Data: ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']"
Description: Autocomplete dropdown is toggled for focused login fields on facebook page load
Location: Facebook page load
Path to .json: modules/data/login_autofill.components.json
```
Expand Down
6 changes: 6 additions & 0 deletions modules/data/login_autofill.components.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
]
},

"facebook-credentials": {
"selectorData": ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']",
"strategy": "css",
"groups": []
},

"username-login-field": {
"selectorData": "//form[h2[text()='Login form:']]//input[@placeholder='username']",
"strategy": "xpath",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def test_case():
]


@pytest.mark.smoke
def test_no_search_engine_suggestions_in_private_window(driver: Firefox):
"""
C3028799 - Verify that in a New Private Window, after selecting a search shortcut,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from modules.page_object_autofill import LoginAutofill
from modules.page_object_generics import GenericPage

BSKY_URL = "https://bsky.app/"
TEST_PAGE = "https://www.facebook.com/"
USERNAME = "username1"
PASSWORD = "password1"
USERNAME2 = "username2"
Expand All @@ -24,7 +24,6 @@ def add_to_prefs_list():
return [("signon.rememberSignons", True)]


@pytest.mark.unstable(reason="Bug 1996241")
def test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load(
driver: Firefox,
):
Expand All @@ -35,22 +34,21 @@ def test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load(
tabs = TabBar(driver)
about_logins = AboutLogins(driver)
login_autofill = LoginAutofill(driver)
generic_page = GenericPage(driver)

# Go to a site that have login field focus on page load
GenericPage(driver, url=BSKY_URL).open()
GenericPage(driver, url=TEST_PAGE).open()
tabs.new_tab_by_button()
tabs.switch_to_new_tab()

# Save 2 set of credentials for the visited site
about_logins.open()
about_logins.add_login(BSKY_URL, USERNAME, PASSWORD)
about_logins.add_login(BSKY_URL, USERNAME2, PASSWORD2)
about_logins.add_login(TEST_PAGE, USERNAME, PASSWORD)
about_logins.add_login(TEST_PAGE, USERNAME2, PASSWORD2)

# Autocomplete dropdown is toggled for focused login fields on page load
tabs.click_tab_by_index(1)
driver.switch_to.window(driver.window_handles[0])
generic_page.get_element("bsky-signin-button").click()

with driver.context(driver.CONTEXT_CHROME):
username_element = login_autofill.get_element("bsky-credentials")
username_element = login_autofill.get_element("facebook-credentials")
assert username_element.get_attribute("ac-value") == USERNAME
2 changes: 1 addition & 1 deletion tests/password_manager/test_multiple_saved_logins.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def test_multiple_saved_logins(driver: Firefox, temp_selectors):
keyboard = Controller()
autofill_popup = AutofillPopup(driver)

# Save 3 sets of credentials for facebook
# Save 3 sets of credentials for Saucedemo
about_logins.open()
about_logins.add_login(SAUCEDEMO_URL, USERNAME, PASSWORD)
time.sleep(0.8)
Expand Down