-
Notifications
You must be signed in to change notification settings - Fork 16
Hani/test addressbar bookmarks when history disabled #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hani/test addressbar bookmarks when history disabled #925
Conversation
soncuteanca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good, not sure about the navigation methods, seams overcomplicated, even not quite reliable.
soncuteanca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better, but I am still not convince about this approach, it still feels a bit fragile but is not like i have solutions. I suggest a new set of eyes here.
philimon-reset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look Good
Relevant Links
Bugzilla: 2000178
TestRail: 3028908
Description of Code / Doc Changes
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!