Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Commit 32f2caa

Browse files
philboothvladikoff
authored andcommitted
fix(metrics): remove the forgot_sent amplitude event (#2078) r=vladikoff
1 parent cc2da2a commit 32f2caa

File tree

2 files changed

+0
-40
lines changed

2 files changed

+0
-40
lines changed

lib/metrics/amplitude.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,6 @@ const EVENTS = {
6161
group: (request, data, metricsContext) => GROUPS[metricsContext.flowType],
6262
event: 'complete'
6363
},
64-
'password.forgot.resend_code.completed': {
65-
group: GROUPS.login,
66-
event: 'forgot_sent'
67-
},
68-
'password.forgot.send_code.completed': {
69-
group: GROUPS.login,
70-
event: 'forgot_sent'
71-
},
7264
'sms.installFirefox.sent': {
7365
group: GROUPS.sms,
7466
event: 'sent'

test/local/metrics/amplitude.js

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -316,38 +316,6 @@ describe('metrics/amplitude', () => {
316316
})
317317
})
318318

319-
describe('password.forgot.resend_code.completed', () => {
320-
beforeEach(() => {
321-
amplitude('password.forgot.resend_code.completed', mocks.mockRequest({}))
322-
})
323-
324-
it('did not call log.error', () => {
325-
assert.equal(log.error.callCount, 0)
326-
})
327-
328-
it('called log.amplitudeEvent correctly', () => {
329-
assert.equal(log.amplitudeEvent.callCount, 1)
330-
const args = log.amplitudeEvent.args[0]
331-
assert.equal(args[0].event_type, 'fxa_login - forgot_sent')
332-
})
333-
})
334-
335-
describe('password.forgot.send_code.completed', () => {
336-
beforeEach(() => {
337-
amplitude('password.forgot.send_code.completed', mocks.mockRequest({}))
338-
})
339-
340-
it('did not call log.error', () => {
341-
assert.equal(log.error.callCount, 0)
342-
})
343-
344-
it('called log.amplitudeEvent correctly', () => {
345-
assert.equal(log.amplitudeEvent.callCount, 1)
346-
const args = log.amplitudeEvent.args[0]
347-
assert.equal(args[0].event_type, 'fxa_login - forgot_sent')
348-
})
349-
})
350-
351319
describe('sms.installFirefox.sent', () => {
352320
beforeEach(() => {
353321
amplitude('sms.installFirefox.sent', mocks.mockRequest({}))

0 commit comments

Comments
 (0)