Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Comments

bug(rtl): fix inputs on RTL locales#1360

Merged
pdehaan merged 1 commit intomasterfrom
issue-1341
Jul 7, 2014
Merged

bug(rtl): fix inputs on RTL locales#1360
pdehaan merged 1 commit intomasterfrom
issue-1341

Conversation

@johngruen
Copy link
Contributor

Fixes #1341

@pdehaan pdehaan added the i18n label Jul 6, 2014
@shane-tomlinson
Copy link

@johngruen - I've never put FxA into an RTL language before, I'm not fully sure what I should be looking for. The PR makes things visually looks much better.

One remaining issue is the tooltip for the password field is attached to the year field, but only in RTL languages:

screen shot 2014-07-07 at 10 32 50

screen shot 2014-07-07 at 10 36 12

@johngruen
Copy link
Contributor Author

@shane-tomlinson weird. will fix.

@pdehaan pdehaan added this to the train-17 (Jul 14) milestone Jul 7, 2014
@johngruen
Copy link
Contributor Author

@shane-tomlinson: FIXED!

@pdehaan
Copy link
Contributor

pdehaan commented Jul 7, 2014

FWIW, the Hebrew text for min-password length looks good to me.

msgid "Must be at least 8 characters"
msgstr "ססמה צריכה להיות באורך של שמונה תווים לפחות"

-- via /locale/he/LC_MESSAGES/client.po:120-121 in mozilla/fxa-content-server-l10n repo.

@johngruen
Copy link
Contributor Author

@pdehaan: can you kick travis?

@vladikoff
Copy link
Contributor

kicked

@pdehaan
Copy link
Contributor

pdehaan commented Jul 7, 2014

👍

Mazel tov!

pdehaan added a commit that referenced this pull request Jul 7, 2014
bug(rtl): fix inputs on RTL locales
@pdehaan pdehaan merged commit 11b1f11 into master Jul 7, 2014
@pdehaan pdehaan deleted the issue-1341 branch July 7, 2014 20:39
@mohamed7afezz
Copy link
Contributor

Seem like this issue is still exist!!
I check it Arabic language.
passwordtooltip
emailtooltip

@TDA
Copy link
Contributor

TDA commented May 20, 2016

@mohamed7afezz Do you mean the position of the tooltip?

@mohamed7afezz
Copy link
Contributor

Yes the it should be float right to beginning of the write in Email and password input,

just like this:
emailtooltipvalid
passwordtooltipvalid

i thinks we need to change the following code when RTL on locals:

.tooltip::before, .tooltip::before {
    right: 12px;
}

.tooltip {
    right: 3px;
}

@mohamed7afezz
Copy link
Contributor

mohamed7afezz commented May 25, 2016

Does we need open this issue again? or just commit the require changes?
@shane-tomlinson

mohamed7afezz added a commit to mohamed7afezz/fxa-content-server that referenced this pull request May 25, 2016
The position of the tooltip should be float right to beginning of the write in Email and password input
@shane-tomlinson
Copy link

Does we need open this issue again? or just commit the require changes?

I merged this PR, but it looks like a new PR is needed to fix the tooltip location, they are still on the left:

screen shot 2016-05-25 at 15 29 51

screen shot 2016-05-25 at 15 30 49

mohamed7afezz added a commit to mohamed7afezz/fxa-content-server that referenced this pull request May 25, 2016
The tooltip should be float right to beginning of the write in Email and password input.
vladikoff pushed a commit that referenced this pull request May 30, 2016
…linson

* Fix #1360 inputs on RTL locales

The tooltip should be float right to beginning of the write in Email and password input.

* Fix indentation declaration for pull #3778
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

password text field and age dropdown have rendering issues in "rtl" locales

6 participants