Conversation
|
@johngruen - I've never put FxA into an RTL language before, I'm not fully sure what I should be looking for. The PR makes things visually looks much better. One remaining issue is the tooltip for the password field is attached to the year field, but only in RTL languages: |
|
@shane-tomlinson weird. will fix. |
|
@shane-tomlinson: FIXED! |
|
FWIW, the Hebrew text for min-password length looks good to me.
-- via /locale/he/LC_MESSAGES/client.po:120-121 in mozilla/fxa-content-server-l10n repo. |
|
@pdehaan: can you kick travis? |
|
kicked |
|
👍 Mazel tov! |
bug(rtl): fix inputs on RTL locales
|
@mohamed7afezz Do you mean the position of the tooltip? |
|
Does we need open this issue again? or just commit the require changes? |
The position of the tooltip should be float right to beginning of the write in Email and password input
The tooltip should be float right to beginning of the write in Email and password input.








Fixes #1341