Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Conversation

@kumar303
Copy link
Contributor

@kumar303 kumar303 commented Sep 2, 2014

No description provided.

kumar303 added a commit that referenced this pull request Sep 2, 2014
Remove node modules from repository
@kumar303 kumar303 merged commit 1fdbf92 into mozilla:master Sep 2, 2014
@kumar303 kumar303 deleted the no-npm branch September 2, 2014 23:45
@cvan
Copy link

cvan commented Sep 3, 2014

why'd you guys decide to remove the node_modules?

@kumar303
Copy link
Contributor Author

kumar303 commented Sep 3, 2014

When you run bower install fxpay the first thing it does is download an 8MB tarball from git. It filters out the node_modules directory after downloading but it seemed pretty unnecessary to make the user wait for 8MBs. However, when I removed node_modules I was unable to install cleanly :( I had to make some version numbers exact instead of loose. I dunno, I suppose we could use a git submodule to solve the tarball problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants