Open a payment popup window (bug 1110228)

[kumar303]

@muffinresearch r?

It's mostly working but I still need to clean up an async problem in the test -- a failure that only happens when the whole suite runs. I think I need to understand the execution flow of mocha async tests better.

But, yeah, payment window opens on Chrome! the "paymentSuccess() function doesn't exist" error in the screencast will be fixed when your shim patch is done.

[andymckay]

nit, lets avoid whitelist, approved list work ok?

[kumar303]

It's just the example app but I fixed it up. I think "map" is actually a more accurate verb here.

[muffinresearch]

But, yeah, payment window opens on Chrome! the "paymentSuccess() function doesn't exist" error in the screencast will be fixed when your shim patch is done.

That's ready for review here: mozilla/spartacus#177

[kumar303]

Hah! After nearly suffocating in a mountain of yak hair, I decided to try upgrading karma and that made the tests pass.

Long story short, it looks like I was wrong about the async execution model of karma/mocha. It appears that karma maybe does block until each test finishes (when done() is called) which is what I thought. I'm still not 100% sure about it though.