User settings page #114
User settings page #114
Conversation
|
Question: Are any of the fields compulsory, except for "username"? Can users leave team name and homepage url blank? @cvan |
|
username and email |
src/media/css/forms.styl
Outdated
There was a problem hiding this comment.
you should make sure that your editor doesn't add superfluous whitespace
There was a problem hiding this comment.
Sorry my bad
On 10 Mar 2014 15:22, "Christopher Van" notifications@github.com wrote:
In src/media/css/forms.styl:
@@ -331,7 +345,7 @@ form {
border: 2px solid lighten(#da3e5a, 80%);
bottom: 5px;
color: lighten(#da3e5a, 20%);
content: attr(data-required);content: attr(data-required);you should make sure that your editor doesn't add superfluous whitespace
Reply to this email directly or view it on GitHubhttps://github.com//pull/114/files#r10420662
.
src/templates/settings.html
Outdated
There was a problem hiding this comment.
you cannot concatenate localised strings like this
There was a problem hiding this comment.
you must do {{ _('Your email cannot be changed. Your password can be changed at <a href="{url}" target="_blank">{domain}</a>', url='https://login.persona.org', domain='login.persona.org') }}
There was a problem hiding this comment.
okay sure will do.
|
can you fix the colour and position of the "read-only" text to better match that of the mock: vs. |
|
can you fix the labels so they're not so close to the inputs? compare those on the settings page vs. those on submit page |
|
also, why are the inputs not as wide as they are on the submit page? meh, doesn't look too bad |
|
remove the underlined |
|
submitting the form doesn't seem to work with the API: |
|
I have made some changes on the API endpoints as well to work together with the fronted. The PR is mozilla/galaxy-api#127. But I will investigate this issue. |
|
rr? @cvan P.S. you need to checkout mozilla/galaxy-api#127 to make this work. |
|
I'll check this in the morning (my morning); thanks! |
src/media/css/forms.styl
Outdated
There was a problem hiding this comment.
lowercase to be consistent: #fff
|
okay. made the changes as required. @cvan |
src/media/css/forms.styl
Outdated
There was a problem hiding this comment.
|
r+wc good work |
Modify user settings page. - Change style to follow mock up design - Add team name and slug field - Convert companyName and companySlug to teamName and teamSlug so that fronted and backend are consistent - Fix some style issues previously presented in form.styl
3 participants
change user settings page to follow the mock up design. add team name and homepage url modification.
this is related to issue #112
the current implementation looks like this: