Bug 1040270 - If an add-on has a ./package.json file, then call it a jetpack

[erikvold]

No description provided.

[Mossop]

We know that we have a zip reader here so you can just call aZipReader.hasEntry

[Mossop]

I don't think the XPIUtils.jsm module is necessary here. Nor is breaking out the Preferences.jsm module, XPIProvider.jsm already has a Prefs helper object, Prefs.getBoolPref should do all you need.

[Mossop]

This code also looks incomplete, it switches to reading package.json, but then still attempts to parse with loadManifestFromRDF.

[edmorley]

(Mass-PR-close)
This PR is against gecko-dev, which is read only. Did you mean to submit it against another repo?
Changes to repos covered by gecko-dev must be made to the hg.mozilla.org repo, which is then mirrored here.

[erikvold]

I don't think the XPIUtils.jsm module is necessary here. Nor is breaking out the Preferences.jsm module, XPIProvider.jsm already has a Prefs helper object, Prefs.getBoolPref should do all you need.

@Mossop, the XPIProvider.jsm file is already more than 7500 lines long. Wouldn't it be easier to manage if it were in separate files and more modular? It feels that way to me, it also makes the function easier to unit test since I do not have to export it from XPIProvider.jsm or get access its' global.

[edmorley]

Replies to this PR spams people watching this repo (I'm watching this repo to point new contributors who mistakenly open PRs not realising they are not accepted) - please can review requests like this take place against personal repos? :-)