Conversation
This is part of what we need to do to prepare for a production deploy (#537).
We actually want storybook deploys for our staging server (https://glean-dictionary-dev.netlify.app), as it may be useful from time to time for debugging.
Contributor
Author
|
@robotblake You may want to unset the |
wlach
commented
Apr 26, 2021
| command = """ | ||
| scripts/build-glean-metadata.py | ||
| npm run build | ||
| if [ "$STORYBOOK" ]; then |
Contributor
Author
There was a problem hiding this comment.
For glean-dictionary-dev (only), I've set this variable to 1 in the GUI. This seems like the most straightforward way of getting the right behaviour for our use case (multiple netlify "apps" for the same repo)
robotblake
approved these changes
Apr 26, 2021
robotblake
left a comment
robotblake
left a comment
There was a problem hiding this comment.
I've gone ahead and removed the config from the Netlify Web UI. LGTM! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of what we need to do to prepare for a production deploy (#537)
Pull Request checklist
fixes, if applicable)