Skip to content

1660120: Make Python bindings installable from source#1203

Merged
mdboom merged 5 commits intomozilla:mainfrom
mdboom:python-source-install
Sep 9, 2020
Merged

1660120: Make Python bindings installable from source#1203
mdboom merged 5 commits intomozilla:mainfrom
mdboom:python-source-install

Conversation

@mdboom
Copy link
Copy Markdown
Contributor

@mdboom mdboom commented Sep 8, 2020

This will ship a Python source package that should be installable on platforms that we don't provide wheels for (if the destination has cargo on the path). Of particular note to support Apple Silicon and more niche OSes like *BSD.

@mdboom mdboom marked this pull request as ready for review September 8, 2020 19:50
@mdboom mdboom requested a review from badboy September 8, 2020 19:50
Copy link
Copy Markdown
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks not too complicated.

One thing I don't understand though: is it bundling ALL source code in the repository, or only the Python + Rust parts (and where does it do that?)

Comment thread glean-core/python/setup.py Outdated
Comment thread setup.py
Comment thread glean-core/python/setup.py Outdated
@mdboom
Copy link
Copy Markdown
Contributor Author

mdboom commented Sep 9, 2020

Looks not too complicated.

One thing I don't understand though: is it bundling ALL source code in the repository, or only the Python + Rust parts (and where does it do that?)

It's bundling the whole code repository (everything checked into git). Not doing that got really complicated (because the rule specification language is kind of broken). Given that the whole package is ~1.3MB compressed, I didn't think it was worth the effort to save a few hundred kb by not including Android, iOS etc. Maybe we file a follow-up bug?

@badboy
Copy link
Copy Markdown
Member

badboy commented Sep 9, 2020

Oh, if it is that small I don't care much. I just couldn't see it in the code how it does it.

@mdboom mdboom merged commit 4619da7 into mozilla:main Sep 9, 2020
@mdboom mdboom deleted the python-source-install branch September 9, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants